Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yarn command syntax in CLI commands #242

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aymanch-03
Copy link

This PR resolves an issue with the yarn CLI command used for installing components. The previous implementation had incorrect syntax, which has now been fixed.

File Updated:
cli-commands.tsx

Copy link

vercel bot commented Feb 6, 2025

@aymanch-03 is attempting to deploy a commit to the Cruip Team on Vercel.

A member of the Team first needs to authorize it.

@aymanch-03 aymanch-03 changed the title fix: correct yarn command syntax in CLI commands Correct yarn command syntax in CLI commands Feb 6, 2025
@aymanch-03 aymanch-03 changed the title Correct yarn command syntax in CLI commands Fix yarn command syntax in CLI commands Feb 12, 2025
@nrjdalal
Copy link
Contributor

This PR resolves an issue with the yarn CLI command used for installing components. The previous implementation had incorrect syntax, which has now been fixed.

File Updated: cli-commands.tsx

#229 would be helpful if you tag the issue along with it no?

Copy link
Contributor

@nrjdalal nrjdalal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also the PR is wrong, should be yarn dlx as mentioned in the issue #229

yarn: npx yarn dlx shadcn@latest add https://originui.com/r/${name}.json
yarn: yarn dlx shadcn@latest add https://originui.com/r/${name}.json

well npx works, good work @aymanch-03

@nrjdalal
Copy link
Contributor

nrjdalal commented Feb 15, 2025

@pasqualevitiello I can see dbb0c5b, it was yarn dlx before, you switched it to npx, I am not using yarn anymore, so would like to learn your findings about it

@nrjdalal
Copy link
Contributor

nrjdalal commented Feb 15, 2025

microsoft/playwright#15369 (comment) seems to answer some of my concerns, closing my issue #229

@nrjdalal
Copy link
Contributor

nrjdalal commented Feb 15, 2025

This PR resolves an issue with the yarn CLI command used for installing components. The previous implementation had incorrect syntax, which has now been fixed.

File Updated: cli-commands.tsx

@aymanch-03 there is no such thing npx dlx, the current implementation npx behaves same as yarn dlx or pnpm dlx, but yarn dlx doesn't seem to exists in some versions of yarn

ohh sorry, @pasqualevitiello the pull request is legit, you have it like npx dlx and the pull request fixes that

@aymanch-03
Copy link
Author

This PR resolves an issue with the yarn CLI command used for installing components. The previous implementation had incorrect syntax, which has now been fixed.
File Updated: cli-commands.tsx

#229 would be helpful if you tag the issue along with it no?

@nrjdalal Sorry, I didn't notice the issue you opened. Thanks for the good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants